Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix diff suppress function ignoring additive_vpc_scope_dns_domain in Autopilot clusters #12567

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix diff suppress function ignoring additive_vpc_scope_dns_domain in Autopilot clusters #12567

wants to merge 1 commit into from

Conversation

Michcioperz
Copy link

@Michcioperz Michcioperz commented Dec 13, 2024 •
edited
Loading

self-appointed successor to #11744

GKE Autopilot allows setting additive VPC scope domain on creation only. However, current implementation of the diff suppress function for Autopilot clusters removes any values in dns_config of Autopilot clusters, all the time.

This change permits setting additive VPC scope domain.

Remaining action items:

  • validate that allowing dns_config.# doesn't cause issues (it seems necessary for dns_config.0.additive_vpc_scope_dns_domain to exist
  • revise test coverage to look for other gaps
  • verify that the change in Autopilot Suppressed Diff Prevents using additive_vpc_scope_dns_domain #11744 to ForceNew when domain changes is exactly the behavior we want and copy it over
  • write the release note below

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: fixed `additive_vpc_scope_dns_domain` being ignored in Autopilot cluster definition

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 148 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 148 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 221
Passed tests: 192
Skipped tests: 12
Affected tests: 17

Click here to see the affected service packages
  • container

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerClusterCustomServiceAccount_withAutopilot
  • TestAccContainerCluster_autopilot_minimal
  • TestAccContainerCluster_autopilot_net_admin
  • TestAccContainerCluster_autopilot_withAdditiveVPC
  • TestAccContainerCluster_autopilot_withDNSConfig
  • TestAccContainerCluster_enableCiliumPolicies_withAutopilot
  • TestAccContainerCluster_withAutopilot
  • TestAccContainerCluster_withAutopilotGcpFilestoreCsiDriver
  • TestAccContainerCluster_withAutopilotKubeletConfig
  • TestAccContainerCluster_withAutopilotNetworkTags
  • TestAccContainerCluster_withAutopilotResourceManagerTags
  • TestAccContainerCluster_withAutopilot_withNodePoolDefaults
  • TestAccContainerCluster_withBinaryAuthorizationEvaluationModeAutopilot
  • TestAccContainerCluster_withCgroupMode
  • TestAccContainerCluster_withCgroupModeUpdate
  • TestAccContainerCluster_withWorkloadALTSConfigAutopilot
  • TestAccContainerCluster_withWorkloadIdentityConfigAutopilot

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_autopilot_withAdditiveVPC [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccContainerClusterCustomServiceAccount_withAutopilot [Error message] [Debug log]
TestAccContainerCluster_autopilot_minimal [Error message] [Debug log]
TestAccContainerCluster_autopilot_net_admin [Error message] [Debug log]
TestAccContainerCluster_autopilot_withDNSConfig [Error message] [Debug log]
TestAccContainerCluster_enableCiliumPolicies_withAutopilot [Error message] [Debug log]
TestAccContainerCluster_withAutopilot [Error message] [Debug log]
TestAccContainerCluster_withAutopilotGcpFilestoreCsiDriver [Error message] [Debug log]
TestAccContainerCluster_withAutopilotKubeletConfig [Error message] [Debug log]
TestAccContainerCluster_withAutopilotNetworkTags [Error message] [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccContainerCluster_withAutopilot_withNodePoolDefaults [Error message] [Debug log]
TestAccContainerCluster_withBinaryAuthorizationEvaluationModeAutopilot [Error message] [Debug log]
TestAccContainerCluster_withCgroupMode [Error message] [Debug log]
TestAccContainerCluster_withCgroupModeUpdate [Error message] [Debug log]
TestAccContainerCluster_withWorkloadALTSConfigAutopilot [Error message] [Debug log]
TestAccContainerCluster_withWorkloadIdentityConfigAutopilot [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@Michcioperz Michcioperz force-pushed the additive-vpc-diff-suppress branch from df4d706 to 5fc163d Compare December 17, 2024 09:34
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 207 insertions(+))
google-beta provider: Diff ( 2 files changed, 207 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 222
Passed tests: 207
Skipped tests: 12
Affected tests: 3

Click here to see the affected service packages
  • container

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_autopilot_withAdditiveVPCMutation
  • TestAccContainerCluster_autopilot_withDNSConfig
  • TestAccContainerCluster_withResourceUsageExportConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_autopilot_withDNSConfig [Debug log]
TestAccContainerCluster_withResourceUsageExportConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccContainerCluster_autopilot_withAdditiveVPCMutation [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@Michcioperz Michcioperz force-pushed the additive-vpc-diff-suppress branch from 5fc163d to d10998a Compare December 17, 2024 10:58
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 210 insertions(+))
google-beta provider: Diff ( 2 files changed, 210 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 222
Passed tests: 209
Skipped tests: 12
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_autopilot_withAdditiveVPCMutation

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccContainerCluster_autopilot_withAdditiveVPCMutation [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
service/container
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michcioperz @modular-magician